added ipfs.ls test spec #150
Conversation
| if (err) { | ||
| throw err | ||
| } | ||
|
|
||
| daemon.add('test/test-folder', {r: true}, (e, r) => { |
There was a problem hiding this comment.
This folder is added too during the add tests, could you use the hash from there?
|
Thank you @fazo96 :) I had in my memory that we had Thank you! |
| }) | ||
| it('should correctly handle a nonexisting hash', function (done) { | ||
| apiClients['a'].ls('surelynotavalidhashheh?', (err, res) => { | ||
| if (err !== null && res === undefined) { |
There was a problem hiding this comment.
We since switched to expect, so you can do something like
expect(err).to.exist
expect(res).to.not.exist
|
Upps sorry for removing the |
|
Will fix it soon 👍 Thanks! |
|
@fazo96 still update to do the last changes so that we can merge this PR? Thank you :) |
While working with the API I noticed weird behavior in
ipfs.ls. Sometimes it calls the callback twice and some other times when there's an error the error object is undefined and the response object is the actual error.After talking briefly with @dignifiedquire I've been trying to write tests to test these and also normal
ipfs.lsfunctionality. Please let me know about anything wrong with the PR 👍Looks like I couldn't reproduce the issue I was having. I'll try again if I happen to run into it, but it was probably some mistake on my end.